Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bigquery validations for partition column and type #5168

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

achettyiitr
Copy link
Member

Description

  • BQ validations for partition column and type.

Linear Ticket

  • Resolves PIPE-1608

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr merged commit a2af47a into release/1.35.x Oct 4, 2024
55 checks passed
@achettyiitr achettyiitr deleted the fix.bigquery-validations branch October 4, 2024 07:17
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.95%. Comparing base (f329d38) to head (caeb8ba).
Report is 2 commits behind head on release/1.35.x.

Files with missing lines Patch % Lines
warehouse/integrations/bigquery/bigquery.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.35.x    #5168      +/-   ##
==================================================
+ Coverage           72.90%   72.95%   +0.04%     
==================================================
  Files                 439      439              
  Lines               51165    51172       +7     
==================================================
+ Hits                37304    37332      +28     
+ Misses              11405    11382      -23     
- Partials             2456     2458       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr restored the fix.bigquery-validations branch October 4, 2024 07:17
@achettyiitr achettyiitr deleted the fix.bigquery-validations branch October 4, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants