Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flipping SourceID & OriginalSourceID during transformation #4887

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Jul 10, 2024

Description

In this PR, we are flipping the OriginalSourceID and SourceID during the transformation and flipping them back once the transformation is done. This is to support replays where transformation can be based on the SourceId of a particular source which we are trying to replay.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Jul 10, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.53%. Comparing base (a80f494) to head (7b4fcf5).

Files Patch % Lines
processor/transformer/transformer.go 11.11% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
+ Coverage   74.51%   74.53%   +0.01%     
==========================================
  Files         428      428              
  Lines       49737    49749      +12     
==========================================
+ Hits        37063    37079      +16     
- Misses      10238    10248      +10     
+ Partials     2436     2422      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula
Copy link
Collaborator

There is no need to merge this one, right? Shall we convert it to draft just in case?

@cisse21
Copy link
Member

cisse21 commented Jul 18, 2024

It is better we merge this. Since we have a lot of customer using sourceID in their user transformations

event.Metadata.OriginalSourceID = originalSourceID
}
}
for _, event := range response.FailedEvents {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these flip backs can be moved to the (*handle)transform(...) Response method at the end where we populate the Response(failedEvents and outClientEvents).

@Sidddddarth
Copy link
Member

Also change the description and PR name since we're going to merge it anyway.

@ktgowtham ktgowtham self-requested a review July 18, 2024 11:03
@BonapartePC BonapartePC changed the title chore: custom server image to replay cars chore: support replays whose transformation is based on sourceId Jul 22, 2024
@BonapartePC
Copy link
Contributor Author

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Actions performed

Summary regeneration triggered.

@BonapartePC BonapartePC changed the title chore: support replays whose transformation is based on sourceId chore: flipping SourceID & OriginalSourceID during transformation Jul 22, 2024
@BonapartePC BonapartePC merged commit 009a071 into master Jul 22, 2024
59 checks passed
@BonapartePC BonapartePC deleted the chore.customServerImageToReplay branch July 22, 2024 06:27
This was referenced Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants