chore: code optimization

rudderlabs · Jul 30, 2024 · 0aaacb6 · 0aaacb6
1 parent 1bf39b3
commit 0aaacb6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Sources/Classes/Headers/Public/RSUtils.h b/Sources/Classes/Headers/Public/RSUtils.h
@@ -50,7 +50,7 @@ NS_ASSUME_NONNULL_BEGIN
 + (BOOL) isValidIDFA:(NSString*)idfa;
 + (BOOL) isSpecialFloatingNumber:(NSNumber *)number;
 +(NSArray*) extractParamFromURL: (NSURL*) deepLinkURL;
-+ (NSString *)delayToString:(int) delay;
++ (NSString *)secondsToString:(int) delay;
 extern unsigned int MAX_EVENT_SIZE;
 extern unsigned int MAX_BATCH_SIZE;
 

diff --git a/Sources/Classes/RSCloudModeManager.m b/Sources/Classes/RSCloudModeManager.m
@@ -75,8 +75,7 @@ - (void) startCloudModeProcessor {
                 break;
             } else if (response.state == NETWORK_ERROR) {
                 int delay = [self->backOff nextDelay];
-                NSString *timeString = [RSUtils delayToString:delay];
-                [RSLogger logDebug:[[NSString alloc] initWithFormat:@"RSCloudModeManager: CloudModeProcessor: Retrying in: %@", timeString]];
+                [RSLogger logDebug:[[NSString alloc] initWithFormat:@"RSCloudModeManager: CloudModeProcessor: Retrying in: %@", [RSUtils secondsToString:delay]]];
                 [RSMetricsReporter report:SDKMETRICS_CM_ATTEMPT_RETRY forMetricType:COUNT withProperties:nil andValue:1];
                 sleep(delay);
             } else { // To handle the status code RESOURCE_NOT_FOUND(404) & BAD_REQUEST(400)

diff --git a/Sources/Classes/RSUtils.m b/Sources/Classes/RSUtils.m
@@ -277,7 +277,7 @@ + (NSString*) serializeSpecialFloatingNumber: (NSNumber *) number {
 }
 
 +(NSArray*) extractParamFromURL: (NSURL*) deepLinkURL{
-    NSMutableArray<NSURLQueryItem *> *queryItems;
+    NSArray<NSURLQueryItem *> *queryItems;
     if (deepLinkURL) {
         // Create NSURLComponents object
         NSURLComponents *components = [NSURLComponents componentsWithURL:deepLinkURL resolvingAgainstBaseURL:NO];
@@ -290,7 +290,7 @@ +(NSArray*) extractParamFromURL: (NSURL*) deepLinkURL{
 unsigned int MAX_EVENT_SIZE = 32 * 1024; // 32 KB
 unsigned int MAX_BATCH_SIZE = 500 * 1024; // 500 KB
 
-+ (NSString *)delayToString:(int) delay {
++ (NSString *)secondsToString:(int) delay {
     int min = delay / 60;
     int sec = min > 0 ? (delay - (min * 60)) : delay;
     NSString *finalString = min > 0 ? [NSString stringWithFormat:@"%dm, %ds", min, sec] : [NSString stringWithFormat:@"%ds", sec];