Add unblock button #299
Open
Add unblock button #299
+97
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaofreitas
reviewed
Oct 5, 2020
| def block | ||
| @user.update_attributes(is_blocked: true) | ||
| @coach = Coach.where(user_id: @user.id).first | ||
| @coach_applications = CoachApplication.where(coach_id: @coach.id) |
There was a problem hiding this comment.
Should we make the changes to the coach applications only for future events? Otherwise we will be changing history.
simaofreitas
reviewed
Oct 5, 2020
| render template: "sessions/new_coach", status: :unauthorized | ||
| elsif params["user_type"] == "admin" | ||
| render template: "sessions/new_admin", status: :unauthorized | ||
| if @user.present? && @user.is_blocked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the column/button name from "blacklist" to "block" and added the possibility to unblock coaches. We also created a test.
@simaofreitas : I "fixed" the test by adding a delete button also to the users who are coaches. The test failed because it could find the button.