Add specs for Module#refinements and Refinement#refined_class
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI-Mozi
force-pushed
the
add_specs_for_refinements_and_refined_class
branch
from
417cc29
to
7f77f08
Compare
core/module/refinements_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| m.refinements.should == [refined_integer, refined_string] |
There was a problem hiding this comment.
minor: Not sure whether the order is guarantied. I suppose it isn't, so we may just sort both arrays, I mean:
Suggested change
| m.refinements.should == [refined_integer, refined_string] | |
| m.refinements.sort.should == [refined_integer, refined_string].sort |
There was a problem hiding this comment.
Not sure if m.refinemets.sort works
There was a problem hiding this comment.
Hm, right. Will sorting by object_id or to_s be working?
There was a problem hiding this comment.
Yes, both are correct. Should I change it to
m2.refinements.sort_by(&:object_id).should == ScratchPad.recorded.sort_by(&:object_id) then?
There was a problem hiding this comment.
Yes.
And in used_refinements (#1028) also order is not guarantied, so sorting probably also makes sense.
AI-Mozi
force-pushed
the
add_specs_for_refinements_and_refined_class
branch
from
7f77f08
to
d8f052d
Compare
andrykonchin
approved these changes
May 16, 2023
AI-Mozi
force-pushed
the
add_specs_for_refinements_and_refined_class
branch
3 times, most recently
from
53b37be
to
256f3ea
Compare
andrykonchin
approved these changes
May 17, 2023
AI-Mozi
force-pushed
the
add_specs_for_refinements_and_refined_class
branch
from
256f3ea
to
354edd9
Compare
|
Thank you for the specs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1016
[Feature #12737]