Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow versions to be specified as an Array. #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sporkmonger
Copy link

So admittedly, this was a quick-and-dirty hack to get this working, but wanted to raise this issue since it has significant implications for anyone who is trying to follow semver. You need to be able to specify gem dependencies in the form '~> x.y', '>= x.y.z' if you want your gem dependency declarations to work for semver projects without breaking horribly anytime someone increments a minor version number.

Obviously, this fix is going to do weird stuff if anyone provides anything but a String or an Array value when they declare their dependencies and I'm not checking for that, however the cause of the problem ought to be obvious in that scenario.

@postmodern
Copy link
Member

How about a helper that does something like Array(things).map(&:dump).join(', ')?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants