Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve permissions when copying files #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachmargolis
Copy link

Hi there,

We have some custom Ore templates that provide default executables, such as a default script/ci for running tests, and we would like the newly-created gems to have these files be executable as well.

Thanks!

cc @Bascule

@ggilder
Copy link

ggilder commented Aug 29, 2014

👍 this would be useful!

@postmodern
Copy link
Member

Sorry for not noticing these PRs sooner! It appears mode: :preserve copies the all of the permission bits. I'm assuming we want to only preserve the executable bit?

@zachmargolis
Copy link
Author

@postmodern thanks! I think preserving all the bits is totally acceptable, and the simplest change we could to get the desired result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants