Use a better and more reliable check for whether a method is the same as Class#new #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
force-pushed
the
better-check-for-Class-new
branch
from
bc6c0b3
to
b68cfb3
Compare
eregon
force-pushed
the
better-check-for-Class-new
branch
from
b68cfb3
to
363c1e4
Compare
JonRowe
reviewed
Apr 22, 2022
Co-authored-by: Jon Rowe <[email protected]>
eregon
force-pushed
the
better-check-for-Class-new
branch
from
1179abe
to
c0c2e44
Compare
JonRowe
added a commit
that referenced
this pull request
Apr 23, 2022
Use a better and more reliable check for whether a method is the same as Class#new
|
Unfortunately this doesn't seem to work on CRuby master, even though it does work on 3.0 and 3.1. |
|
I fixed that CRuby issue, and with a rerun of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test would fail without the change.
This also helps for TruffleRuby support (rspec/rspec-metagem#68), as TruffleRuby does not plan to replicate that CRuby inconsistency/bug (https://bugs.ruby-lang.org/issues/18729).