Fix async assertions in test files (#1510)

* fix: await assertSnapshot in test files for async assertions
rrweb-io · Jun 18, 2024 · 5d6dbbb · 5d6dbbb
1 parent 47b0fbb
commit 5d6dbbb
Show file tree

Hide file tree

Showing 8 changed files with 94 additions and 92 deletions.
diff --git a/.changeset/bright-socks-clap.md b/.changeset/bright-socks-clap.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/all/test/cross-origin-iframe-packer.test.ts b/packages/all/test/cross-origin-iframe-packer.test.ts
@@ -149,7 +149,7 @@ describe('cross origin iframes & packer', function (this: ISuite) {
         const unpackedSnapshots = packedSnapshots.map((packed) =>
           unpack(packed),
         ) as eventWithTime[];
-        assertSnapshot(unpackedSnapshots);
+        await assertSnapshot(unpackedSnapshots);
       });
     });
   });

diff --git a/packages/plugins/rrweb-plugin-console-record/test/index.test.ts b/packages/plugins/rrweb-plugin-console-record/test/index.test.ts
@@ -87,7 +87,7 @@ describe('rrweb-plugin-console-record', () => {
       'window.snapshots',
     )) as eventWithTime[];
     // The snapshots should containe 1 console log, not multiple.
-    assertSnapshot(snapshots);
+    await assertSnapshot(snapshots);
   });
 
   it('should record console messages', async () => {
@@ -123,6 +123,6 @@ describe('rrweb-plugin-console-record', () => {
     const snapshots = (await page.evaluate(
       'window.snapshots',
     )) as eventWithTime[];
-    assertSnapshot(snapshots);
+    await assertSnapshot(snapshots);
   });
 });
diff --git a/packages/rrweb-snapshot/test/integration.test.ts b/packages/rrweb-snapshot/test/integration.test.ts
@@ -153,7 +153,7 @@ describe('integration tests', function (this: ISuite) {
           'blob:http://localhost:xxxx/...',
         );
 
-      assertSnapshot(rebuildHtml);
+      await assertSnapshot(rebuildHtml);
     });
   }
 
@@ -427,7 +427,7 @@ describe('iframe integration tests', function (this: ISuite) {
       null,
       2,
     );
-    assertSnapshot(snapshotResult);
+    await assertSnapshot(snapshotResult);
   });
 });
 
@@ -470,6 +470,6 @@ describe('shadow DOM integration tests', function (this: ISuite) {
       null,
       2,
     );
-    assertSnapshot(snapshotResult);
+    await assertSnapshot(snapshotResult);
   });
 });