Add CODEOWNERS to enable automatic review-requests #3320
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatilai
requested review from
a team and
ffesti
and removed request for
a team
|
I'm wondering which of the three supported locations this should go: top-level (as in this PR), docs/ or .github/. We don't exactly have a gang of specialist maintainers in rpm so having it on top level is maybe pointless because it doesn't really convey any real information. |
|
I'd lean toward the .github dir, just to have all GH specific stuff nicely stashed in one place. |
|
Yup, Wizard pointed this out as the first thing as we went out 😆 : as long as the only purpose of this file is to serve GH automation, it belongs to .github. If that chanages one day, we can always move it later. I'll update the PR. |
Since this only serves the purpose of GH review automation, it belongs in out of sight in the .github repo. If this one day becomes useful for other purposes as well, we can always move it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.