brp-remove-la-files: Remove symlinks, too

[ffesti]

As we check for file contents delete symlink before looking at regular files.

Resolves: #3304

[pmatilai]

A test? You don't need to create a project with .la files in it and spec and all, just write a bunch of files to a directory and run the script on that.

I'd place the invocations in a for loop over the file type - otherwise it takes some squinting to see that it's all identical except for l/f passed to -type.

[ffesti]

Loop and test case added.

[fundawang]

what if just

find "$RPM_BUILD_ROOT" -type f,l -name '*.la'

[pmatilai]

find "$RPM_BUILD_ROOT" -type f,l -name '*.la'

That's pretty much how this script started its life as, but it was discovered to remove non-libtool files too, see 432a911

Unfortunately we didn't demand test-cases for that stuff back then.

[fundawang]

find "$RPM_BUILD_ROOT" -type f,l -name '*.la'

That's pretty much how this script started its life as, but it was discovered to remove non-libtool files too, see 432a911

Unfortunately we didn't demand test-cases for that stuff back then.

I mean can throw loop away:

find "$RPM_BUILD_ROOT" -type f,l -name '*.la' 2>/dev/null -print0 |
  xargs -0 grep --fixed-strings '.la - a libtool library file' --files-with-matches --null |
  xargs -0 rm --force

this is the same as current loop, but better to read. please note that -type f,l accepts more than one file type:
https://www.gnu.org/software/findutils/manual/html_node/find_html/Type.html