createrepo_c tools: switch default compression to zstd #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to pollute the current repo with temp decompressed files because its contents might matter for tests.
In a couple places where option `--compress-type` was used with `zstd` its switched to `gz` so the test still tests the option.
jan-kolarik
force-pushed
the
zstd_default
branch
from
4dff0a7
to
00b91c6
Compare
|
I think the dnf5 tests are using createrepo_c from nightly so it will not have the zstd default change -> it will fail in the I have manually triggered the nightly build. Once it rebuilds createrepo_c it should work. |
|
@jan-kolarik It is working now. 🙂 |
|
Similar thing should be probably also introduced for the dnf4 branch. |
I have made: #1319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains: #1218 which should be merged first.
I just wanted to avoid too many conflicts as both PRs are changing a lot of the same lines.
For: rpm-software-management/createrepo_c#371