Managesieve plugin: add spam settings engine #9074
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozen-sky
commented
Jul 19, 2023
| @@ -10,9 +10,9 @@ static function setUpBeforeClass(): void | |||
| } | |||
|
|
|||
| /** | |||
| * Test vacation_form() | |||
| * Test forward_form() | |||
There was a problem hiding this comment.
When making the test, i saw this was incorrect labelled in the Forward test, as such corrected this. Its not related to the goal of this PR
alecpl
requested changes
Oct 8, 2023
|
|
||
| setProperty($spam, 'spam', ['list' => []]); | ||
|
|
||
| $result = $spam->forward_form([]); |
| } | ||
|
|
||
| $rule['type'] = 'if'; | ||
| $rule['name'] = "Spam filter settings"; |
|
@frozen-sky: Have you progressed on your PR? |
Thank you for reminding me. The local version is a bit progressed but not finalized yet. I will try to push a bit on it next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a similar way as the out-of-office and forward engines, the option to render a more sophisticated/specific form to set spam filtering values. It allows to configure enable/disable spam-filtering and adjust the threshold when filtering should happen.
There is an option to add ACL Allow list entries, which will allow emails to skip the filtering action.
Configuration defaults and options are added to the managesieve configuration example.
As for localization: It is unknown to me how RoundCube works with localizations. For now I did not touch the localizations except English (US). I can do an effort to fill in most translations, however, I do not speak all the languages in the table