Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #918 #942

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

fix: issue #918 #942

wants to merge 1 commit into from

Conversation

MarcoMagriDev
Copy link

Image and Camera plugins disable automatically on rviz2 window minimization. This behavior is really annoying in particular when you have the plugin nested into groups (each time you minimize the rviz window you need to traverse the tree and enable to plugin again).
In rviz (ROS1) this is not the case, correct me if I am wrong.

This pull request aims to solve this "undesired" behavior taking the cue from the solution proposed by @kudoukidd in #918.
With this change the plugin does not disable automatically on window minimization.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @clalancette do you have any comments about this?

@ahcorde
Copy link
Contributor

ahcorde commented Jan 24, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The only thing I'll say is that ROS 1 has the exact same code: https://github.com/ros-visualization/rviz/blob/d122ab111213c3ad4ac50756e4fd933d01982263/src/rviz/display.cpp#L366-L367

So I'm not sure that this explains a difference in behavior.

@afrixs
Copy link

afrixs commented Dec 4, 2023

I have been using Rviz since ROS1 kinetic and this annoying behavior has always been present. (Not only when minimizing the window but also when switching between workspaces in Ubuntu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants