Remove the loading_ascii_stl_files_fail (#1125)

In assimp version 5.2.2 and earlier (i.e. what is in Ubuntu Jammy), attempting to load ASCII STL files through assimp fails. However, in assimp version 5.3.1 and later (what is in Ubuntu Noble and RHEL-9), attempting to load ASCII STL files through assimp succeeds. Because this is functionality that might reasonably work, but won't work on all platforms, just remove the test. Signed-off-by: Chris Lalancette <[email protected]>
ros2 · Jan 19, 2024 · fc28194 · fc28194
1 parent dffc11d
commit fc28194
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 26 deletions.
diff --git a/rviz_rendering_tests/ogre_media_resources/test_meshes/ascii.stl b/rviz_rendering_tests/ogre_media_resources/test_meshes/ascii.stl
diff --git a/rviz_rendering_tests/test/mesh_loader_test.cpp b/rviz_rendering_tests/test/mesh_loader_test.cpp
@@ -104,13 +104,6 @@ TEST_F(MeshLoaderTestFixture, can_load_stl_files) {
   ASSERT_EQ(expected_vertex_count, actual_vertex_count);
 }
 
-TEST_F(MeshLoaderTestFixture, loading_ascii_stl_files_fail) {
-  /// Load an ascii STL file. Note that only binary STL files are supported.
-  std::string mesh_path = "package://rviz_rendering_tests/test_meshes/ascii.stl";
-
-  ASSERT_FALSE(rviz_rendering::loadMeshFromResource(mesh_path));
-}
-
 TEST_F(MeshLoaderTestFixture, loading_invalid_short_stl_files_fail) {
   /// Load an invalid STL binary file (size < 84 bytes).
   std::string mesh_path = "package://rviz_rendering_tests/test_meshes/invalid_short.stl";