Create PublisherData within NodeData #278
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
class rmw_publisher_data_t
withclass PublisherData
which provides thread-safe access to publisher functions. An instance ofPublisherData
is created via theNodeData
class.rmw_publisher->data
is now set tormw_node_t
. The assumption here is that the node outlives the publisher similar to the assumption that the context outlives the node. From thisrmw_node_t
raw_ptr, we are able to obtain it'sNodeData
and then lookup thePublisherData
for the publisher.