Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Count API Creation #364

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Message Count API Creation #364

wants to merge 1 commit into from

Conversation

CursedRock17
Copy link

This PR is meant in preparation for issue #1109 in the rcl repository by creating a rmw API for counting messages a Subscription is ready to receive.

@CursedRock17
Message Count API Creation
4e46bf8 
Signed-off-by: CursedRock17 <[email protected]>
@fujitatomoya
Copy link
Collaborator

@CursedRock17 thanks for creating PR.

IMO, this requires RMW change, i would suggest that before moving forward, probably it would be nice to have discussion on basic design describes how we could implement this underlying rmw implementation, including client interfaces? maybe REP required, i am not sure... @clalancette @wjwwood WDYT?

@clalancette
Copy link
Contributor

IMO, this requires RMW change, i would suggest that before moving forward, probably it would be nice to have discussion on basic design describes how we could implement this underlying rmw implementation, including client interfaces? maybe REP required, i am not sure... @clalancette @wjwwood WDYT?

Yeah, agreed. I'd like to see draft PRs, or at least documentation, on how we would implement this for rmw_fastrtps, rmw_cyclonedds, rmw_connextdds, and rmw_zenoh.

@clalancette clalancette added the more-information-needed Further information is required label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CursedRock17 @fujitatomoya @clalancette