Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml types #781

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions launch/launch/utilities/type_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@
from typing import Type
from typing import Union

# yaml has type annotations in typeshed, but those cannot be installed via rosdep
# since there is no definition for types-PyYAML
import yaml # type: ignore
import yaml

from .ensure_argument_type_impl import ensure_argument_type
from .normalize_to_list_of_substitutions_impl import normalize_to_list_of_substitutions
Expand Down
1 change: 1 addition & 0 deletions launch/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<test_depend>ament_flake8</test_depend>
<test_depend>ament_pep257</test_depend>
<test_depend>ament_mypy</test_depend>
<test_depend>python3-types-pyyaml</test_depend>
<test_depend>python3-pytest</test_depend>

<export>
Expand Down