Skip to content

Commit

Permalink
drop the warning and guard, lean on the graceful degradation as recom…
Browse files Browse the repository at this point in the history
…mended in review

Signed-off-by: Daniel Stonier <[email protected]>
  • Loading branch information
stonier committed Jul 16, 2019
1 parent 13018ea commit 96d4fd9
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions launch/launch/actions/execute_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -529,13 +529,6 @@ async def __execute_process(self, context: LaunchContext) -> None:
))
except KeyError:
emulate_tty = self.__emulate_tty
# guard against windows - tty emulation is not yet working
# https://github.com/ros2/launch/issues/268
if emulate_tty and platform.system() == 'Windows':
self.__logger.warning(
'tty emulation not yet supported on windows, disabling'
)
emulate_tty = False
try:
transport, self._subprocess_protocol = await async_execute_process(
lambda **kwargs: self.__ProcessProtocol(
Expand Down

0 comments on commit 96d4fd9

Please sign in to comment.