Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README.md for dummy_robot_bringup. #574

Open
wants to merge 6 commits into
base: rolling
Choose a base branch
from

Conversation

cardboardcode
Copy link
Contributor

Purpose of Pull Request

This pull request adds a README.md to dummy_robot_bringup as part of efforts to address the issue highlighted in #531.

…ocumented expected behaviour. Verified instructions.

Signed-off-by: Bey Hao Yun <[email protected]>
@cardboardcode cardboardcode changed the title Added dummy_robot_bringup README.md. Added README.md for dummy_robot_bringup . Jul 26, 2022
@cardboardcode cardboardcode changed the title Added README.md for dummy_robot_bringup . Added README.md for dummy_robot_bringup. Jul 26, 2022
@audrow audrow self-assigned this Jul 26, 2022
@audrow audrow self-requested a review July 26, 2022 17:01
@cardboardcode cardboardcode marked this pull request as draft August 13, 2022 16:19
…ions for better cross-platform-compatibility.

Signed-off-by: Bey Hao Yun <[email protected]>
@cardboardcode cardboardcode marked this pull request as ready for review January 23, 2023 15:53
@adityapande-1995
Copy link
Contributor

Testing for dependency cycles :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Bey Hao Yun <[email protected]>
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve the conflicts here @cardboardcode ? Looks good to me otherwise.

@cardboardcode
Copy link
Contributor Author

Rebased pull request branch to newly updated main rolling branch. Conflicts should now be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants