Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SDK for ROS2 Rolling #1203

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sgstreet
Copy link

@sgstreet sgstreet commented Aug 12, 2024

This PR tries to resurrect PR #988 for Rolling to enable OpenEmbedded SDK cross-compilation. These changes allow demos, examples and examples_interfaces packages to be built using the resulting SDK. To build the SDK use:

$ bitbake ros2-image-sdktest -c do_populate_sdk

Install the resulting SDK, setup a ROS2 workspace containing demos, examples and example_interfaces and build the workspace using the follow script:

export ROS_VERSION=2
export ROS_PYTHON_VERSION=3
export ROS_AUTOMATIC_DISCOVERY_RANGE=SUBNET
export ROS_DISTRO=rolling
export PYTHONPATH=$OECORE_NATIVE_SYSROOT/usr/lib/python3.12/site-packages:$OECORE_TARGET_SYSROOT/opt/ros/rolling/lib/python3.12/site-packages
export AMENT_PREFIX_PATH=$OECORE_TARGET_SYSROOT/opt/ros/rolling
usr/share:$OECORE_TARGET_SYSROOT/opt/ros/rolling/share:$OECORE_TARGET_SYSROOT/opt/ros/rolling/lib/cmake"

colcon build \
--merge-install \
--install-base $PWD/install/arm64 \
--cmake-args \
" -DCMAKE_TOOLCHAIN_FILE=$CMAKE_TOOLCHAIN_FILE" \
" -DCMAKE_STAGING_PREFIX=$PWD/install/arm64" \
" -DBUILD_TESTING=OFF"

Install the $PWD/install/arm64 on the target device. Setup the device workspace:

$ . /opt/ros/rolling/setup.bash
$ . ./arm64/local_setup.bash

Run any of the rclcpp examples to demonstrate the valid cross-compilation.

@sgstreet sgstreet marked this pull request as draft August 12, 2024 22:35
@sgstreet
Copy link
Author

sgstreet commented Aug 12, 2024

The python nodes are not functional:

root@raspberrypi5:~# ros2 run demo_nodes_py talker
Traceback (most recent call last):
  File "/opt/ros/rolling/bin/ros2", line 33, in <module>
    sys.exit(load_entry_point('ros2cli==0.33.0', 'console_scripts', 'ros2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2cli/cli.py", line 91, in main
    rc = extension.main(parser=parser, args=args)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2run/command/run.py", line 70, in main
    return run_executable(path=path, argv=args.argv, prefix=prefix)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2run/api/__init__.py", line 64, in run_executable
    process = subprocess.Popen(cmd)
              ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/root/arm64/lib/demo_nodes_py/talker'

The file /home/root/arm64/lib/demo_nodes_py/talker exists and contains the expected python code. Does someone have an idea on how to debug this?

@jiaxshi
Copy link
Contributor

jiaxshi commented Aug 19, 2024

Hi @sgstreet
Greate job! I have done similar work on humble, I suggest to add TOOLCHAIN_HOST_TASK in a include file

+require conf/distro/include/ros2-sdk.inc

Could you please full build https://github.com/ros2/examples or https://github.com/ros2/demos with SDK env?

@sgstreet
Copy link
Author

Could you please full build https://github.com/ros2/examples or https://github.com/ros2/demos with SDK env?

Yes. I can build demos, example_interfaces and example ros2 packages using the SDK env. The C++ nodes are functional,unfortunately the python packages are not, see above.

@jiaxshi
Copy link
Contributor

jiaxshi commented Aug 22, 2024

The python nodes are not functional:

root@raspberrypi5:~# ros2 run demo_nodes_py talker
Traceback (most recent call last):
  File "/opt/ros/rolling/bin/ros2", line 33, in <module>
    sys.exit(load_entry_point('ros2cli==0.33.0', 'console_scripts', 'ros2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2cli/cli.py", line 91, in main
    rc = extension.main(parser=parser, args=args)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2run/command/run.py", line 70, in main
    return run_executable(path=path, argv=args.argv, prefix=prefix)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2run/api/__init__.py", line 64, in run_executable
    process = subprocess.Popen(cmd)
              ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.12/subprocess.py", line 1955, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/root/arm64/lib/demo_nodes_py/talker'

The file /home/root/arm64/lib/demo_nodes_py/talker exists and contains the expected python code. Does someone have an idea on how to debug this?

Hi @sgstreet
You can check the python shebang in python executor. HOST path is included like:

#!/local/mnt2/workspace/install_dir/sysroots/x86_64-qcomsdk-linux/usr/bin/python3

@@ -13,3 +13,8 @@ EXTRA_OECMAKE:prepend:class-native = "\
-DCMAKE_PREFIX_PATH='${STAGING_DIR_NATIVE}${ros_prefix};${STAGING_DIR_NATIVE}${prefix}' \
-DCMAKE_INSTALL_PREFIX:PATH='${ros_prefix}' \
"

EXTRA_OECMAKE:prepend:class-nativesdk = "\
-DCMAKE_PREFIX_PATH='${STAGING_DIR_NATIVE}/opt/ros/${ROS_DISTRO};${STAGING_DIR_NATIVE}${ros_prefix};${STAGING_DIR_NATIVE}${prefix}' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ${ros_prefix} to replace opt/ros/${ROS_DISTRO}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will test and feedback. Sorry for the delay, my attention has been distracted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change still allows the SDK to build and run, but I suspect it is not used in my case.

@@ -25,11 +25,13 @@ export AMENT_PREFIX_PATH="${STAGING_DIR_HOST}${prefix};${STAGING_DIR_NATIVE}${pr

inherit cmake python3native

PYTHONPATH:prepend:class-nativesdk = "${STAGING_DIR_NATIVE}/opt/ros/${ROS_DISTRO}/lib/python3.12/site-packages:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Use ${ros_prefix} to replace opt/ros/${ROS_DISTRO}
  2. Use ${PYTHON_BASEVERSION} instead of python3.12 is better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will test and feedback. Sorry for the delay, my attention has been distracted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 1. fails to build the SDK with the following error for the packages rosidl-typesupport-interface, rosidl-cmake, rcutils and rosidl-generator-type-description

| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_configure
| -- Found ament_cmake: 2.6.0 (/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake)
| -- Found Python3: /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/usr/bin/python3-native/python3 (found version "3.12.3") found components: Interpreter
| Traceback (most recent call last):
|   File "/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/package_templates/templates_2_cmake.py", line 21, in <module>
|     from ament_package.templates import get_environment_hook_template_path
| ModuleNotFoundError: No module named 'ament_package'
| CMake Error at /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/ament_cmake_package_templates-extras.cmake:41 (message):
| 
|   execute_process(/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/usr/bin/python3-native/python3
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/package_templates/templates_2_cmake.py
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/build/ament_cmake_package_templates/templates.cmake)
|   returned error code 1
| Call Stack (most recent call first):
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/ament_cmake_coreConfig.cmake:41 (include)
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake/ament_cmake_export_dependencies-extras.cmake:15 (find_package)
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-cmake/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake/ament_cmakeConfig.cmake:41 (include)
|   CMakeLists.txt:5 (find_package)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a corollary, remove ${STAGING_DIR_NATIVE}/opt/ros/${ROS_DISTRO} from EXTRA_OECMAKE:prepend:class-nativesdk -D-DCMAKE_PREFIX_PATH line results in similar errors:

| CMake Error at CMakeLists.txt:5 (find_package):
|   By not providing "Findament_cmake.cmake" in CMAKE_MODULE_PATH this project
|   has asked CMake to find a package configuration file provided by
|   "ament_cmake", but CMake did not find one.
| 
|   Could not find a package configuration file provided by "ament_cmake" with
|   any of the following names:
| 
|     ament_cmakeConfig.cmake
|     ament_cmake-config.cmake
| 
|   Add the installation prefix of "ament_cmake" to CMAKE_PREFIX_PATH or set
|   "ament_cmake_DIR" to a directory containing one of the above files.  If
|   "ament_cmake" provides a separate development package or SDK, be sure it
|   has been installed.

for rosidl/rosidl-typesupport-interface and rosidl-cmake while the following error generated for rcutils:

| CMake Error at CMakeLists.txt:16 (find_package):
|   By not providing "Findament_cmake_python.cmake" in CMAKE_MODULE_PATH this
|   project has asked CMake to find a package configuration file provided by
|   "ament_cmake_python", but CMake did not find one.
| 
|   Could not find a package configuration file provided by
|   "ament_cmake_python" with any of the following names:
| 
|     ament_cmake_pythonConfig.cmake
|     ament_cmake_python-config.cmake
| 
|   Add the installation prefix of "ament_cmake_python" to CMAKE_PREFIX_PATH or
|   set "ament_cmake_python_DIR" to a directory containing one of the above
|   files.  If "ament_cmake_python" provides a separate development package or
|   SDK, be sure it has been installed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appear to be a problem with the ${ros_prefix} value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 2. generates the variation of the following error for packages rosidl-typesupport-interface, rosidl-cmake, rcutils, rosidl-parser and rosidl-generator-type-description:

| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_configure
| -- Found ament_cmake: 2.6.0 (/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake)
| -- Found Python3: /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/usr/bin/python3-native/python3 (found version "3.12.3") found components: Interpreter
| Traceback (most recent call last):
|   File "/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/package_templates/templates_2_cmake.py", line 21, in <module>
|     from ament_package.templates import get_environment_hook_template_path
| ModuleNotFoundError: No module named 'ament_package'
| CMake Error at /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/ament_cmake_package_templates-extras.cmake:41 (message):
| 
|   execute_process(/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/usr/bin/python3-native/python3
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/package_templates/templates_2_cmake.py
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/build/ament_cmake_package_templates/templates.cmake)
|   returned error code 1
| Call Stack (most recent call first):
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake_core/cmake/ament_cmake_coreConfig.cmake:41 (include)
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake/ament_cmake_export_dependencies-extras.cmake:15 (find_package)
|   /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling/share/ament_cmake/cmake/ament_cmakeConfig.cmake:41 (include)
|   CMakeLists.txt:5 (find_package)

Copy link
Author

@sgstreet sgstreet Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigating value of '${ros_prefix}' for the native-sdk

$ bitbake-getvar -r nativesdk-rosidl-typesupport-interface --value ros_prefix
/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-oesdk-linux/opt/ros/rolling

while for the target:

$ bitbake-getvar -r rosidl-typesupport-interface --value ros_prefix
/opt/ros/rolling

These values are prefixed with STAGING_DIR_NATIVE

bitbake-getvar -r rosidl-typesupport-interface --value STAGING_DIR_NATIVE
/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/cortexa76-oe-linux/rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native

The actual value being used is /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-oesdk-linux/opt/ros/rolling which is not present in the build path for the package

ls -al /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native//usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-oesdk-linux/opt/ros/rolling
ls: cannot access '/home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/x86_64-nativesdk-oesdk-linux/nativesdk-rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native//usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-oesdk-linux/opt/ros/rolling': No such file or directory

while the path /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/cortexa76-oe-linux/rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native//opt/ros/rolling is present:

$ ls -al /home/stephen/Workspace/yocto/pi5/build/tmp-glibc/work/cortexa76-oe-linux/rosidl-typesupport-interface/4.7.0-1/recipe-sysroot-native/opt/ros/rolling
total 16
drwxr-xr-x  4 stephen stephen 4096 Aug 27 09:46 .
drwxr-xr-x  3 stephen stephen 4096 Aug 27 09:46 ..
drwxr-xr-x  3 stephen stephen 4096 Aug 27 09:46 lib
drwxr-xr-x 20 stephen stephen 4096 Aug 27 09:46 share

My interpretation is that '${ros_prefix}' is incorrect for the building the nativesdk recipes.

Copy link
Author

@sgstreet sgstreet Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search meta-ros for ros_prefix yields the following definition in meta-ros-common/classes/ros_opt_prefix.bbclass:

ros_prefix ?= "${base_prefix}/opt/ros/${ROS_DISTRO}"

I did not find (could be wrong here) any other prior definitions of ros_prefix so base_prefix must be the governing variable. I found base_prefix in openembedded-core/meta/classes-recipe/nativesdk.bbclass:

base_prefix = "${SDKPATHNATIVE}"

Tracking SDKPATHNATIVE to openembedded-core/meta/conf/bitbake.conf the definition is

SDK_SYS = "${SDK_ARCH}${SDK_VENDOR}-${SDK_OS}"
SDKPATH = "/usr/local/oe-sdk-hardcoded-buildpath"
SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"

Which starts to make sense in explaining the observed behavior. I think that the current value of ros_prefix is wrong for building the SDK. Unfortunately I'm not sure the correct way to fix this would be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your details. I didn't realize the prefix_xx are changed in nativesdk.bbclass.

base_prefix = "${SDKPATHNATIVE}"
prefix = "${SDKPATHNATIVE}${prefix_nativesdk}"

My intention is to use the variables defined in ros_opt_prefix.bbclass.

Copy link
Author

@sgstreet sgstreet Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems right, may be we need to add an variable with it's default value as /opt/ros/${ROS_DISTRO}. This would allow the some flexibility when constructing paths for the nativesdk.

@sgstreet
Copy link
Author

@jiaxshi Still hacking on the shebang path.

@jiaxshi
Copy link
Contributor

jiaxshi commented Aug 28, 2024

@jiaxshi Still hacking on the shebang path.

python executor can be found after changing shebang path. And one more thing, if you build python-library, you should add PYTHON_SOABI to rename library which is named with "x86".

-DPYTHON_SOABI=cpython-310-aarch64-linux-gnu

You can refer to #1204 for details.

@sgstreet
Copy link
Author

@jiaxshi here is the contents of my talker executor (are these correct words?)

#!/home/stephen/Workspace/ros2-dev/sdk/sysroots/x86_64-oesdk-linux/usr/bin/python3
# EASY-INSTALL-ENTRY-SCRIPT: 'demo-nodes-py==0.34.2','console_scripts','talker'
import re
import sys

# for compatibility with easy_install; see #2198
__requires__ = 'demo-nodes-py==0.34.2'

try:
    from importlib.metadata import distribution
except ImportError:
    try:
        from importlib_metadata import distribution
    except ImportError:
        from pkg_resources import load_entry_point


def importlib_load_entry_point(spec, group, name):
    dist_name, _, _ = spec.partition('==')
    matches = (
        entry_point
        for entry_point in distribution(dist_name).entry_points
        if entry_point.group == group and entry_point.name == name
    )
    return next(matches).load()


globals().setdefault('load_entry_point', importlib_load_entry_point)


if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(load_entry_point('demo-nodes-py==0.34.2', 'console_scripts', 'talker')())

As you pointed out the shebang is clearly wrong. Can you point out the code which generates this talker file? Maybe I can figure out which path is wrong.

@sgstreet
Copy link
Author

sgstreet commented Aug 28, 2024

python executor can be found after changing shebang path. And one more thing, if you build python-library, you should add PYTHON_SOABI to rename library which is named with "x86".

-DPYTHON_SOABI=cpython-310-aarch64-linux-gnu

You can refer to #1204 for details.

I tried this, how should I verify the impact?

Further, for none python ROS2 packages the following warnings are generated:

CMake Warning:
  Manually-specified variables were not used by the project:

    PYTHON_SOABI

which is harmless but annoying. I think we need another place to add the PYTHON_SOABI.

@jiaxshi
Copy link
Contributor

jiaxshi commented Aug 29, 2024

I think the shebang path is added by native python interpreter.

CMake Warning:
  Manually-specified variables were not used by the project:

    PYTHON_SOABI

The warning is because is not used by none-python packages. If there's way to add the default value to native interpreter is better.

@sgstreet
Copy link
Author

I think the shebang path is added by native python interpreter.
Are you saying the native python3 is adding the shebang? I would have thought either the python setup or some ament_python make script was doing this but I'm not sure where to look. Maybe I'm confused? I have limit python skills.


CMake Warning:

  Manually-specified variables were not used by the project:



    PYTHON_SOABI

The warning is because is not used by none-python packages. If there's way to add the default value to native interpreter is better.

Or maybe superflores could add during recipe generation.

@sgstreet
Copy link
Author

sgstreet commented Oct 2, 2024

@jiaxshi here is the contents of my talker executor (are these correct words?)

#!/home/stephen/Workspace/ros2-dev/sdk/sysroots/x86_64-oesdk-linux/usr/bin/python3
# EASY-INSTALL-ENTRY-SCRIPT: 'demo-nodes-py==0.34.2','console_scripts','talker'
import re
import sys

# for compatibility with easy_install; see #2198
__requires__ = 'demo-nodes-py==0.34.2'

try:
    from importlib.metadata import distribution
except ImportError:
    try:
        from importlib_metadata import distribution
    except ImportError:
        from pkg_resources import load_entry_point


def importlib_load_entry_point(spec, group, name):
    dist_name, _, _ = spec.partition('==')
    matches = (
        entry_point
        for entry_point in distribution(dist_name).entry_points
        if entry_point.group == group and entry_point.name == name
    )
    return next(matches).load()


globals().setdefault('load_entry_point', importlib_load_entry_point)


if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw?|\.exe)?$', '', sys.argv[0])
    sys.exit(load_entry_point('demo-nodes-py==0.34.2', 'console_scripts', 'talker')())

As you pointed out the shebang is clearly wrong. Can you point out the code which generates this talker file? Maybe I can figure out which path is wrong.

I patched colcon build to generate a better/correct shebang for python packages builds. See 5965ca6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants