-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ht4 Smotrova Lilit #42
Open
SmotrovaLilit
wants to merge
5
commits into
romabelka:master
Choose a base branch
from
SmotrovaLilit:ht4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ed320d
Merge pull request #1 from romabelka/master
SmotrovaLilit 47fb7b7
Merge pull request #2 from romabelka/master
SmotrovaLilit 91e111c
Merge pull request #3 from romabelka/master
SmotrovaLilit e43576b
HT4.1 Переписать articles на хранилище ключ -> значение.
SmotrovaLilit c5dfc5b
HT4.2 Добавить в CommentList форму нового коммента
SmotrovaLilit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import React, { Component } from 'react' | ||
import { connect } from 'react-redux' | ||
import PropTypes from 'prop-types' | ||
import { addComment } from '../../ac' | ||
|
||
class CommentForm extends Component { | ||
static propTypes = { | ||
articleId: PropTypes.string.isRequired, | ||
addComment: PropTypes.func.isRequired | ||
} | ||
|
||
state = { | ||
commentText: '', | ||
author: '' | ||
} | ||
|
||
handleSubmit = (e) => { | ||
e.preventDefault() | ||
const { author, commentText } = this.state | ||
const { addComment, articleId } = this.props | ||
|
||
addComment({ author, commentText, articleId }) | ||
} | ||
|
||
handleChangeAuthor = (e) => { | ||
this.setState({ author: e.target.value }) | ||
} | ||
|
||
handleChangeCommentText = (e) => { | ||
this.setState({ commentText: e.target.value }) | ||
} | ||
|
||
render() { | ||
const { author, commentText } = this.state | ||
|
||
return ( | ||
<form onSubmit={this.handleSubmit} style={{ padding: '25px' }}> | ||
<label> | ||
<div>Author:</div> | ||
<input | ||
type="text" | ||
onChange={this.handleChangeAuthor} | ||
value={author} | ||
/> | ||
</label> | ||
<label> | ||
<div>Comment:</div> | ||
<textarea | ||
onChange={this.handleChangeCommentText} | ||
value={commentText} | ||
/> | ||
</label> | ||
<div> | ||
<input type="submit" value="Add comment" /> | ||
</div> | ||
</form> | ||
) | ||
} | ||
} | ||
|
||
export default connect(null, { | ||
addComment | ||
})(CommentForm) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { ADD_COMMENT } from '../constants' | ||
|
||
export default (store) => (next) => (action) => { | ||
if (action.type !== ADD_COMMENT) { | ||
return next(action) | ||
} | ||
|
||
return next({ | ||
...action, | ||
payload: { | ||
...action.payload, | ||
id: new Date().getTime() | ||
} | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,30 @@ | ||
import { DELETE_ARTICLE } from '../constants' | ||
import { normalizedArticles as defaultArticles } from '../fixtures' | ||
import { ADD_COMMENT, DELETE_ARTICLE } from '../constants' | ||
import { normalizedArticles } from '../fixtures' | ||
|
||
const defaultArticles = normalizedArticles.reduce( | ||
(acc, article) => ({ | ||
...acc, | ||
[article.id]: article | ||
}), | ||
{} | ||
) | ||
console.log(defaultArticles) | ||
|
||
export default (articleState = defaultArticles, action) => { | ||
const { type, payload } = action | ||
|
||
switch (type) { | ||
case ADD_COMMENT: | ||
const article = articleState[payload.articleId] | ||
|
||
return { | ||
...articleState, | ||
[article.id]: { | ||
...article, | ||
comments: [...article.comments, payload.id] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ок, только comments может быть undefined |
||
} | ||
} | ||
|
||
case DELETE_ARTICLE: | ||
return articleState.filter((article) => article.id !== payload.id) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
через мидлвары будет проходить каждый экшин, они должны быть максимально общими, завязывать на конкретные экшины - не лучшее решение