Make Aftman skip untrusted tools #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Aftman is installing tools, use
--skip-untrustedso that if there is an untrusted tool, we skip it instead of erroring.Background
Aftman just released
v0.2.8which adds a new flag,--skip-untrustedthat installs only trusted tools.Currently, if you have an untrusted tool then the Rojo extension would just error. Instead, we should just skip the untrusted tools and let the user deal with it later.
Notes
If the user has a version of Aftman lower than v0.2.8 then the install will error because the flag
--skip-untrustedhasn't been added and therefore doesn't exist.