Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for artifacts compressed as '.gz' #73

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Added support for artifacts compressed as '.gz' #73

merged 2 commits into from
Aug 28, 2024

Conversation

meruiden
Copy link
Contributor

@meruiden meruiden commented Aug 27, 2024 •
edited
Loading

Some repos compress artifacts to .gz files, which this PR adds support for:

https://github.com/evilmartians/lefthook/releases

> rokit add evilmartians/lefthook
🚀 Added version 1.7.14 of tool lefthook (took 250.96ms)
> where lefthook
C:\Users\user\.rokit\bin\lefthook.exe
> lefthook version
1.7.14

closes: #72

@meruiden meruiden mentioned this pull request Aug 27, 2024
Closed
Dekkonot
Dekkonot reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the changelog but otherwise this looks good to me.

@meruiden meruiden changed the title Add support for .gz files Added support for artifacts compressed as '.gz' Aug 28, 2024
@meruiden meruiden requested a review from Dekkonot August 28, 2024 06:28
@Dekkonot
Copy link
Member

I will merge once CI finishes (didn't realize it needed to be approved still)!

@Dekkonot Dekkonot merged commit ccee0ca into rojo-rbx:main Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more assets formats (lefthook)
2 participants
@meruiden @Dekkonot