Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process group behavior on Windows #51

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

filiptibell
Copy link
Collaborator

This PR fixes the process group behavior on Windows and makes sure descendant processes are properly reaped together with the main Rokit runner process job that spawned them. This unfortunately broke due presumably to some internal mechanisms in command-group and therefore its successor crate process-wrap changing.

  • Version 1 of command-group works as expected (this is what Foreman and Aftman use)
  • Version 2+ of command-group did not initially work as expected - but now works the same as v1 after migrating to the .group() builder API
  • Unfortunately, no versions of process-wrap have worked out so far. Their examples of migrating from different versions of the command-group crate do not preserve the same behavior that the older crate had.

@filiptibell filiptibell merged commit d081d15 into main Jul 17, 2024
10 checks passed
@filiptibell filiptibell deleted the windows-fix-process-groups branch July 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant