Fix an improperly handled FileNotFound error on initial self-install
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the first Rokit run with self-install, it tries to create the `.rokit` directory in the user's home, using `create_dir_all` (which creates the tool storage directories and their parent, `.rokit`). The underlying issue was that Rokit first tried to load or create the manifest files, which fail, since the parent directory does not exist. This has been fixed by reordering `try_join!` call - we now create the directories first, and then the manifests, and since the directory creations are operations blocking with `await`; `try_join!` runs tasks concurrently, essentially waiting for the directory creations to finish first.
|
Upon reconsideration, this isn't a proper solution, #42 is instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the first Rokit run with self-install, it tries to create the
.rokitdirectory in the user's home, usingcreate_dir_all(which creates the tool storage directories and their parent,.rokit).The underlying issue was that Rokit first tried to load or create the manifest files, which fail, since the parent directory does not exist.
This has been fixed by reordering
try_join!call - we now create the directories first, and then the manifests, and since the directory creations are operations blocking withawait;try_join!runs tasks concurrently, essentially waiting for the directory creations to finish first.