Increment crate versions in prep for release #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, this does not involve updating the reflection database like it normally does. This is because a recent change (see #439) caused Roblox to start serializing an
Int32attribute by default onLighting, which we don't want to write as a default. Since our patching mechanism doesn't let us patch inherited properties right now, we can't patch the default value forLighting.Attributesand instead would have to patch it forInstance.Attributes.While we need to fix that in the future, I don't think it's a huge deal right now to just not update the database in favor of getting a patch out soon(tm).