Make rbx_reflector library
#417
Open
+44
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
I'm hesitant to do this because it places a maintenance burden on us; we suddenly have to respect semver, keep a changelog, and maintain docs for rbx_reflector.
I am okay with it, since it's something we should probably do anyway but I'm not the only rbx-dom maintainer. @kennethloeffler any objections?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on an automated database reflection generation tool and it would be nice to use
rbx_reflectorin its backend.This PR makes
rbx_reflectora separate crate and exposes all CLI subcommands as simple functions. I also removedpublish = falsebecause we can now publish it to crates.io.