Improve rbx_reflector Roblox Studio automation and logging on macOS
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethloeffler
requested changes
Apr 22, 2024
Co-authored-by: Kenneth Loeffler <[email protected]>
Co-authored-by: Kenneth Loeffler <[email protected]>
Oh yeah 😅 I also updated the |
kennethloeffler
approved these changes
Apr 23, 2024
Comment on lines
+1
to
+4
| if game.Name ~= "defaults-place.rbxlx" then | ||
| return | ||
| end | ||
|
|
There was a problem hiding this comment.
Nice, this will help when Roblox Studio's "Reload plugins on file changed` setting is enabled
kennethloeffler
pushed a commit
to kennethloeffler/rbx-dom
that referenced
this pull request
Jul 21, 2024
…rojo-rbx#407) This PR brings automatic place saving to macOS, so it now works exactly the same as on Windows. It also pipes the `stdout` and `stderr` streams to `null` to get rid of extreme verbosity on macOS. Lastly, it adds a check to the injected plugin so it won't run outside of the defaults place, which is useful when other Roblox Studio instances are open and Roblox Studio's "Reload plugins on file changed" setting is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings automatic place saving to macOS, so it now works exactly the same as on Windows. It also pipes the
stdoutandstderrstreams tonullto get rid of extreme verbosity on macOS.Sequence.01.mp4