Fix FILE resource leak #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue rogersce#53, which notes that an exception thrown when loading an npz file would cause an open FILE pointer to be leaked. This bug could be triggered intentionally (via specially-crafted NPZ files), so fixing it is a priority.
Fixes issue rogersce#52, which notes that an exception thrown when loading an npy file would cause an open FILE pointer to be leaked. This bug could be triggered intentionally (via specially-crafted NPY files), so fixing it is a priority.
skaiware
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes resource leaks in
npy_load()andnpz_load()that would occur if an exception were to be thrown during load. Because NPY files can be constructed deliberately to trigger such exceptions, addressing this leak is vital for cases where programs may load user-supplied NPY files and attempt recovery on error.