Adding target options to cnpy-static to be linked against as a subdirectory module #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogersce
reviewed
Aug 10, 2019
| @@ -19,6 +19,8 @@ install(TARGETS "cnpy" LIBRARY DESTINATION lib PERMISSIONS OWNER_READ OWNER_WRIT | |||
|
|
|||
| if(ENABLE_STATIC) | |||
| add_library(cnpy-static STATIC "cnpy.cpp") | |||
| target_link_libraries(cnpy-static PUBLIC ${ZLIB_LIBRARIES}) | |||
| target_include_directories(cnpy-static PUBLIC ".") | |||
There was a problem hiding this comment.
Can we remove this line or is it necessary? I can build on my machine w/o it.
There was a problem hiding this comment.
specifically, the target_include_directories command
There was a problem hiding this comment.
Can you build when including it as a subdirectory?
My CMakeFiles looks like this, more or less...
add_subdirectory(external/cnpy)
[...]
add_executable(tests ${SOURCES})
target_link_libraries(tests Catch2::Catch2 cnpy-static gsl::gsl-lite)
I may be doing it wrong though :) I clone cnpy as a submodule and include it this way, is there a better approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a couple lines in the CMakeFiles.txt to be able to build against the static library. It works when the library is built using
add_subdirectoryand should not impact existing targets.