license added to about page. #81
Conversation
|
Thanks for PR! I just created the task, the maintainer of roc-droid is @ortex, he does the review :) |
| recyclerView.adapter = adapter | ||
| } | ||
|
|
||
| val arrayList = listOf<License>(License("roc-droid", "org.roc-streaming.roctoolkit:roc-android:0.2.1")) |
There was a problem hiding this comment.
goal was to somehow (probably with gradle plugin e.g. https://github.com/jk1/Gradle-License-Report) collect dependencies and their licenses automatically, not hardcode it
|
You should be able to add the license file to assets and do something like this: https://github.com/JamesOsborn-SE/eat-poop-you-cat-android/blob/6d75740d57687db2c1365bda17b3745f5f945e67/app/src/main/java/dev/develsinthedetails/eatpoopyoucat/utilities/ReadMetadata.kt https://stackoverflow.com/questions/26706843/adding-an-assets-folder-in-android-studio |
|
@JamesOsborn-SE What I meant in the issue is to add licenses of all dependencies, not just license of roc droid, because some of them may require attribution. And I guess it would be nice to do it automatically because dependencies can change. Though I guess this feature is not that important. |
|
@githubashutoshsoni Hey, do you have any plans on this PR, or should we close it? |
No, I’m busy with my job right now. So don’t have the time to do it. |
Added license page @gavv can you review please?