Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving examples into an examples folder in the root directory #88

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

martincarapia
Copy link

Fixes issue #3
All the example files are in their respective folder inside the examples folder in the root directory.

@auscompgeek
Copy link
Member

Are there any reasons why

  • the top-level directory is all caps?
  • each subdirectory has an example prefix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these Python examples are intended to have the executable bit set. Please don't remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find the executable bit set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot of file header in GitHub PR files view, with mode change highlighted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, how would I go about fixing that? I've never encountered that before. I'm sorry I'm new to that.

@martincarapia
Copy link
Author

I used caps so that it was obvious they where examples, and I used example prefix so that they weren't mistaken with the original core.

@virtuald
Copy link
Member

virtuald commented Apr 9, 2024

I used caps so that it was obvious they where examples, and I used example prefix so that they weren't mistaken with the original core.

I see your point, but I prefer examples/cscore

@martincarapia martincarapia force-pushed the refactoring branch 2 times, most recently from ed5152a to e0b7ae6 Compare June 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants