Ouster lidar - log UDP #990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3d
reviewed
Apr 16, 2024
| if isinstance(out_data, list): | ||
| assert len(out_data) == 3, out_data # unsupported output data | ||
| url, header, data = out_data | ||
| request = urllib.request.Request(url, data=data, headers=header, method='POST') |
There was a problem hiding this comment.
I would keep the original Request names, i.e. headers everywhere
m3d
reviewed
Apr 16, 2024
| else: | ||
| assert False, out_data # unsupported output data | ||
|
|
||
| with urllib.request.urlopen(request, timeout=0.5) as f: |
There was a problem hiding this comment.
the timeout should be part of module config, and 0.5s maybe as default? something like request_timeout_sec??
m3d
reviewed
Apr 16, 2024
| self.input_thread = Thread(target=self.run_input, daemon=True) | ||
| bus.register('raw', 'response') | ||
| self.url = config.get('url') | ||
| self.output = config.get('output', False) |
There was a problem hiding this comment.
is not url and output completely independent? If yes then they do not have to be in one common module or what is the motivation to keep it together?
m3d
reviewed
Apr 16, 2024
| from osgar.node import Node | ||
|
|
||
|
|
||
| class OusterLidarDummy(Node): |
m3d
reviewed
Apr 16, 2024
| assert not self.configuration_saved # The configuration should be delivered only once. | ||
| if self.verbose: | ||
| print(data) | ||
| self.publish("lidar_config", data.decode()) |
There was a problem hiding this comment.
what is the data you receive? does not decode need encoding?
m3d
reviewed
Apr 16, 2024
| @@ -175,18 +175,29 @@ def _send(self, data): | |||
|
|
|||
| class LogHTTP: | |||
There was a problem hiding this comment.
maybe add new class LogHTTPRequest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt to log data from Ouster lidar. Only raw UDP packet now.
There is a new modification of the HTTP driver which allows POST method and "two side" communication.