Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move useful code from subt to osgar #965

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Move useful code from subt to osgar #965

merged 7 commits into from
Nov 1, 2023

Conversation

tajgr
Copy link
Collaborator

@tajgr tajgr commented Oct 26, 2023 •
edited
Loading

Moving:

  • push.py,
  • pull.py,
  • odoimuloc.py,
  • local_planner.py

This code can be and is used in other projects. The location in the osgar is more reasonable.

@tajgr tajgr requested a review from m3d October 26, 2023 20:56
@m3d
Copy link
Member

m3d commented Nov 1, 2023

pull/push makes sense to move to drivers (maybe it should be io) instead ... but I am not sure about the odoimuloc and local_planner. These are not really "drivers" but rather some useful Nodes. We can discuss it later today on the call

m3d
m3d approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@m3d m3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked that local_planner is in lib now, OK. Still not sure about odoimuloc?

@tajgr tajgr merged commit 0d7d612 into master Nov 1, 2023
6 checks passed
@tajgr tajgr deleted the feature/move-from-subt branch November 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m3d m3d m3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tajgr @m3d