Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy record via drivers/replay #963

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Dummy record via drivers/replay #963

merged 3 commits into from
Sep 19, 2023

Conversation

tajgr
Copy link
Collaborator

@tajgr tajgr commented Sep 7, 2023

This PR fixes streams registration and adds a sleep option to slow down recording.
I used it during testing of node for lidar processing. This tool may partially replace a real sensor if needed.

@tajgr tajgr requested a review from m3d September 7, 2023 20:36
@tajgr
Copy link
Collaborator Author

tajgr commented Sep 12, 2023

Copy link
Member

@m3d m3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, feel free to merge. This PR fixes the bug with registration although "one day" I would change it do "timescale", where 0 would be instant publishing without sleep and 1 would be real-time of original recording (i.e. variable sleep) ... not needed now. Thanks m.

@tajgr tajgr merged commit 517cf80 into master Sep 19, 2023
6 checks passed
@tajgr tajgr deleted the feature/dummy_record branch September 19, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants