-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subt.launch: add generic process launcher #511
Conversation
Entry can be added to a config file with driver `subt.launch.Launch` that can be used to launch a generic process when other osgar nodes are started and terminated when other nodes are terminated.
What is the plan for communicating with such a module/process? |
For now it can be used to run these:
osgar/subt/script/run_eduro_ros.sh Line 6 in bf2448d
etc. So in general, the plan is to leverage more zmq while simplifying its startup and shutdown so that even multi-process run can be started and shutdown as single-process without adding startup scripts.
|
With #525 we can finally use this even with variable arguments such as robot name. |
test.py
Outdated
@@ -2,4 +2,9 @@ | |||
|
|||
if __name__ == "__main__": | |||
import unittest | |||
unittest.main(module=None) | |||
import unittest.loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add comment here why the simple solution does not work? (I noticed failure on Windows, so it is probably related)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why it shows here as a new code since it has already been integrated to master as #510.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have merged master into this PR and the code you are referring to has disappeared so it has been an artifact of the master not being merged here. And to tell the truth, I no longer remember why exactly it has not worked.
Entry can be added to a config file with driver
subt.launch.Launch
that can be used to launch a generic process when other osgar nodes
are started and terminated when other nodes are terminated.