Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subt.launch: add generic process launcher #511

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Conversation

zbynekwinkler
Copy link
Member

Entry can be added to a config file with driver subt.launch.Launch
that can be used to launch a generic process when other osgar nodes
are started and terminated when other nodes are terminated.

Entry can be added to a config file with driver `subt.launch.Launch`
that can be used to launch a generic process when other osgar nodes
are started and terminated when other nodes are terminated.
@zbynekwinkler zbynekwinkler requested review from jisa and m3d May 22, 2020 13:38
Base automatically changed from feature/relative-imports-tests to master May 22, 2020 14:30
@jisa
Copy link
Collaborator

jisa commented May 23, 2020

What is the plan for communicating with such a module/process?

@zbynekwinkler
Copy link
Member Author

For now it can be used to run these:

roslaunch proxy sim.launch --wait robot_name:=$ROBOT_NAME &

ssh -t edurojetson "source /opt/ros/melodic/setup.bash;source ~/ros_ws/devel/setup.bash; roslaunch robot eduro.launch"

etc. So in general, the plan is to leverage more zmq while simplifying its startup and shutdown so that even multi-process run can be started and shutdown as single-process without adding startup scripts.

@zbynekwinkler
Copy link
Member Author

With #525 we can finally use this even with variable arguments such as robot name.

test.py Outdated
@@ -2,4 +2,9 @@

if __name__ == "__main__":
import unittest
unittest.main(module=None)
import unittest.loader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add comment here why the simple solution does not work? (I noticed failure on Windows, so it is probably related)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why it shows here as a new code since it has already been integrated to master as #510.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged master into this PR and the code you are referring to has disappeared so it has been an artifact of the master not being merged here. And to tell the truth, I no longer remember why exactly it has not worked.

@zbynekwinkler zbynekwinkler merged commit a80da17 into master Jun 8, 2020
@zbynekwinkler zbynekwinkler deleted the feature/launch branch June 8, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants