Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of google/protobuf v4.x #31

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Adding support of google/protobuf v4.x #31

merged 2 commits into from
Jul 22, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Jul 21, 2024

Q A
Bugfix?
Breaks BC?
New feature? ✔️
Issues #roadrunner-php/issues#35

@msmakouz msmakouz added the enhancement New feature or request label Jul 21, 2024
@msmakouz msmakouz self-assigned this Jul 21, 2024
Copy link

coderabbitai bot commented Jul 21, 2024

Walkthrough

The changes include updating the version constraint for the google/protobuf dependency in the composer.json file, expanding the allowed versions from only ^3.7 to include ^4.0. This modification ensures better compatibility with newer library versions while still supporting the existing ones. Additionally, a new suppression rule for MissingClassConstType warnings is introduced in the psalm.xml file, enhancing error management without altering existing functionality.

Changes

File Change Summary
composer.json Updated dependency version constraint for google/protobuf from ^3.7 to `^3.7
psalm.xml Added suppression rule for MissingClassConstType in the <issueHandlers> section

Poem

In the garden where the code does grow,
A rabbit hops, with a joyful glow.
Versions updated, oh what a delight,
Flexibility blooms, as code takes flight!
With protobuf's grace, both old and new,
We dance through changes, hopping with you! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e5e86f and 38053e6.

Files selected for processing (1)
  • composer.json (1 hunks)
Additional comments not posted (1)
composer.json (1)

45-45: LGTM! Verify compatibility with the new version range.

The updated version constraint for google/protobuf from ^3.7 to ^3.7 || ^4.0 is approved.

Ensure that the project is fully compatible with both version ranges.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (3643ce3) to head (9d82f6a).
Report is 1 commits behind head on 3.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x      #31   +/-   ##
=========================================
  Coverage     77.07%   77.07%           
  Complexity       95       95           
=========================================
  Files             8        8           
  Lines           253      253           
=========================================
  Hits            195      195           
  Misses           58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 38053e6 and 9d82f6a.

Files selected for processing (1)
  • psalm.xml (1 hunks)
Additional comments not posted (1)
psalm.xml (1)

23-23: LGTM! The suppression rule for MissingClassConstType is correctly added.

The suppression rule is consistent with the existing configuration and correctly formatted.

@msmakouz msmakouz merged commit ddb3e21 into 3.x Jul 22, 2024
6 checks passed
@msmakouz msmakouz deleted the feat/protobuf-v4 branch July 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants