Skip to content
This repository has been archived by the owner on Nov 7, 2020. It is now read-only.

update async.js answers to Promises #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update async.js answers to Promises #110

wants to merge 1 commit into from

Conversation

gitmihalis
Copy link

Regarding issue #104, I used Promises to answer the asynchronous tests. Vanilla JS to the rescue!

@rmurphey
Copy link
Owner

This is great. To land this, I think we'd want to:

  • remove the jquery dependency from the project
  • consider shipping a Promise polyfill -- maybe not needed given support

I'd also love to see the XHR converted to use fetch, but after thinking about it I decided that's outside the scope of this PR.

@gitmihalis
Copy link
Author

Did remove the jQuery dependency from the js-assesments project to coincide with the new async answers.

Copy link

@bennowak bennowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hasn't this been merged yet?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants