Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image#morphology and Image#morphology_channel #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Image#morphology and Image#morphology_channel #40

wants to merge 4 commits into from

Conversation

naquad
Copy link

@naquad naquad commented Dec 2, 2011

Implementation of Image#morphology and Image#morphology_channel methods, also implemented KernelInfo class used by morphology and bitwise or for enums.

@rmagick-temp
Copy link
Owner

Thanks for doing this. I will merge it once I have gone over it and build some tests for it.

Moncef

-----Original Message-----
From: Daniel Fort [mailto:[email protected]]
Sent: Friday, December 02, 2011 9:58 AM
To: rmagick
Subject: [rmagick] Image#morphology and Image#morphology_channel (#40)

Implementation of Image#morphology and Image#morphology_channel methods, also implemented KernelInfo class used by morphology and bitwise or for enums.

You can merge this Pull Request by running:

git pull https://github.com/naquad/rmagick master

Or you can view, comment on it, or merge it online at:

rmagick/rmagick#40

-- Commit Summary --

  • added KernelInfo class, added Image#morphology and Image#morphology_channel
  • rdoc comment fix + rb_funcall -> rb_class_new_instance
  • added bitwise OR to enum
  • doc + refactoring

-- File Changes --

M ext/RMagick/rmagick.h (22)
M ext/RMagick/rmenum.c (36)
M ext/RMagick/rmimage.c (72)
A ext/RMagick/rmkinfo.c (247)
M ext/RMagick/rmmain.c (95)

-- Patch Links --

https://github.com/rmagick/rmagick/pull/40.patch
https://github.com/rmagick/rmagick/pull/40.diff


Reply to this email directly or view it on GitHub:
rmagick/rmagick#40

@naquad
Copy link
Author

naquad commented Dec 3, 2011

Ok. Please notify me in case some code needs rewrite / modification.

@rmagick-temp
Copy link
Owner

Ok.

-----Original Message-----
From: Daniel Fort [mailto:[email protected]]
Sent: Friday, December 02, 2011 9:34 PM
To: rmagick
Subject: Re: [rmagick] Image#morphology and Image#morphology_channel (#40)

Ok. Please notify me in case some code needs rewrite / modification.


Reply to this email directly or view it on GitHub:
rmagick/rmagick#40 (comment)

@dylancopeland
Copy link

Any update on this? Morphology functionality would be greatly appreciated.

@hayesmp
Copy link

hayesmp commented Jan 27, 2014

@rmagick Can this be merged? EDIT: Oh, I see. Needs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants