warning: assigned but unused variable - current #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed rmagick-temp#122: lib/RMagick.rb is overwritten by lib/rmagick.rb on case-insensitive systems
Added Image#resample!
Fixed rmagick-temp#83: test_import_export(Import_Export_UT) in Import_Export.rb fails
Changed Image#resample to calling ResampleImage (related rmagick-temp#29, rmagick-temp#45)
Fixed: test_limit_resources (Magick_UT) in Magick.rb fails rmagick-temp#126
…bian based systems
…ttps://gist.github.com/theschoolmaster/0b14516537072382e08d for a gist of a current Magick-config as built from ImageMagick source on debian jessie/sid)
proof of concept for using pkg-config in place of Magick-config on debian based systems
Enable builds on OS X
|
Please resubmit this PR at https://github.com/gemhome/rmagick/ rmagick/rmagick is actually a github user we no longer have access to. Thanks! |
Travis doesn't evaluate Bash conditions in the scope of the entire script, so this seems to be the only way of doing this.
Green OS X Build
Added (commented out) RedCarpet to the Gemfile as it is used by build_tarball.rake to convert README.rc into README.html build_tarball.rake also builds and rewrites a bunch in doc but doc doesn't go anywhere right now. Re: updating the docs at http://www.imagemagick.org/RMagick/doc/ Tim Hunter, the original author writes: I wrote the original RMagick doc (http://www.imagemagick.org/RMagick/doc/) files by hand. No automatic generation... back when I was actively working on RMagick I usually communicated with John Cristy, the creator of ImageMagick. I suggest using the general ImageMagick contact page http://www.imagemagick.org/script/contact.php to send him a note, or post a note in the Developers forum on the ImageMagick discourse server http://www.imagemagick.org/discourse-server/ I'm not sure yet what to do with: See https://github.com/rmagick/rmagick/wiki/Todo Doxyfile # doxygen Doxyfile generates doc/c README-Mac-OSX.txt # look at diff when moved to rubyforge? These are almost certainly legacy setup.rb uninstall.rb post-install.rb post-clean.rb post-setup.rb metaconfig See https://github.com/rmagick/rmagick/wiki/Release-Process 1. update ChangeLog 2. in RMagick_git git tag RMagick_2-13-1 git push origin tag RMagick_2-13-1 3. in RMagick_cvs # edit the username in build_tarball.rake to be you on line 18 rake -f build_tarball.rake clean release=RMagick_2-13-1 rake -f build_tarball.rake release=RMagick_2-13-1 # should create all the zip/gem files you need 4. (dead) Upload the files as a new release to RubyForge, remove old 5. Update the RMagick website’s news section with information on the release (in index.html)
Remove build support for RAA and rubyforge; annotate Rake tasks
Fix wrong relative path for lib/rmagick/version
Add Contributor's Guide
Change indentation style to follow ruby style guide (2 spaces)
I went with a file for the method here. There are a buttload of `Image` specs and it seems like the better option to having a 6000 line spec file.
Convert more tests to specs
update rubocop config
Call `pkg-config` instead of `Magick-config`, if `graphicsmagick-libmagick-dev-compat` is installed. This is because GraphicsMagick has `Magick-config` and it might be called.
This is because GraphicsMagick has `convert` and it might be called.
X11 library may be omitted.
Windows has another `convert` command.
If PATH is set appropriately, it is unnecessary to use `--with-opt-dir`, `--with-opt-lib`, and `--with-opt-include` options.
More tests converted to RSpec
Fix build problems
Remove style checks from Travis build
I am personally not sure if issues of this kind exist on other platforms, but I did not encounter them. Also see: rmagick/rmagick#225
Add README hint for bitness under Windows
Both versions have reaches their EOL
Drop support for Ruby 1.8 and 1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a ruby warning "assigned but unused variable".