Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation with ocaml 5 (and maybe 4.14 ?) #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compilation with ocaml 5 (and maybe 4.14 ?) #53

wants to merge 1 commit into from

Conversation

craff
Copy link
Contributor

@craff craff commented Jun 17, 2022

No description provided.

@cfcs
Copy link
Collaborator

cfcs commented Sep 29, 2022

The code in src/ (the imagelib findlib package) should not depend on unix; code that depends on unix should be in unix/ (the imagelib.unix findlib package), see top of the README.

The kprintf -> ksprintf patch looks good; looks like upstream finally deprecated it. :)

What is the build error you're seeing @craff ?

@cfcs
Copy link
Collaborator

cfcs commented Sep 29, 2022

Oh, see #54 for the unix thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craff @cfcs