Upgrade to React Native 0.72.17 #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option 'importsNotUsedAsValues' is deprecated and will stop functioning in TypeScript 5.5
This commit also includes tests for the isEnum helper function
Upgrades to the latest versions that still support node 16
When upgrading from 4, they recommend starting from scratch
lancesnider
commented
Sep 25, 2024
| @@ -0,0 +1 @@ | |||
| commitlint --edit $1 | |||
There was a problem hiding this comment.
This and the new .husky/pre-commit files do the same thing that this used to:
"husky": {
"hooks": {
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
"pre-commit": "yarn lint && yarn typescript"
}
},
lancesnider
commented
Sep 25, 2024
There was a problem hiding this comment.
The changes in this file happen automatically when running yarn bootstrap.
lancesnider
commented
Sep 25, 2024
| @@ -7,7 +7,6 @@ | |||
| "allowUnreachableCode": false, | |||
| "allowUnusedLabels": false, | |||
| "esModuleInterop": true, | |||
| "importsNotUsedAsValues": "error", | |||
There was a problem hiding this comment.
Deprecated in the next version of typescript.
HayesGordon
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we start upgrading to React Native
0.73.xand0.74.x, we want to get everything upgrades to the latest version of0.72.x. This PR:0.72.7to0.72.17based on the upgrade helper.0.74.x.yarn testno longer fails.Testing
Note: This'll only work on projects using RN <= 0.72
Run
yarn testnode_modulesin the parent director and insideexamples//examples/ios/Podsyarn bootstrapyarn example startito start an iOS simulator and/orato start an AndroidYou might have an issue where Expo tries to run on a previously used device, rather than a Simulator. If that happens, run
yarn example ios --simulator="iPhone 15"(or whatever device).To test on a real device, open
example/ios/RiveReactNativeExample.xcworkspacein XCode.