Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle pagination support to games view #376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaimegarjr
Copy link

Mark the type contribution you are making:

  • Experimental feature (new functionality that can be selectively enabled/disabled)
  • Bug fix (non-breaking change which fixes an issue)

Description

  • Why is this change necessary?
    This PR is to add pagination support to the games view when toggling the page control buttons at the bottom of the screen. Right now, a user can tap these buttons and will stay on the current page while the icons toggle between selection.

  • Why did you decide on this solution?
    This PR is also a continuation of Update page control on games view #101, which seems to have been stagnant for a few years. I've implemented the changes needed based on the comments posted on that PR.

Testing

List all iOS versions and devices you've tested this change on.

Example Configurations:

  • My Mac (Designed for iPad), iOS 17.4

I'd like to test running it on an iPhone device, but I've been getting this error.
Does anyone have any idea on how to get around this? Any help is much appreciated 🙏.

Checklist

General (All PRs)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I've tested my changes with different device + OS version configurations

Experimental Feature-specific

  • Added property to ExperimentalFeatures struct annotated with @Feature
  • Uses @Option's to persist all feature-related data
  • Locked all behavior changes behind ExperimentalFeatures.shared.[feature].isEnabled runtime check
  • Isolates changes to separate files as much as possible (e.g. via Swift extensions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant