Implement advisory locks and some other methods #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements optional (highly encouraged) advisory locking if the model class responds to `with_advisory_lock`. The easiest way to use this feature is to install the `with_advisory_lock` gem (https://github.com/ClosureTree/with_advisory_lock). Have a look at the README for all possible configuration options.
If the `move_to` (or `move_to!`) method is called with a position that exceeds the collection's size, lexorank would have positioned the record in the middle (using 'U' as the rank). With this change calling it with such a position will position the record at the end of the collection.
This makes the concern that is included into all models a lot smaller and extracts all our internal state and methods into a separate class. This also prevents unnecessary pollution of model classes that use lexorank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.