Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm-ostree: Setup readonly sysroot for ostree & rw karg #5427

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

poncovka
Copy link
Contributor

  • Enable read only sysroot in the ostree repo config.
  • Add rw to the kernel arguments to keep statefull parts of the system (/var & /etc) writable.
  • Update units tests to account for the new rw karg

(cherry-picked from a commit 0e00c90)

Related: RHEL-2250

- Enable read only sysroot in the ostree repo config.
- Add `rw` to the kernel arguments to keep statefull parts of the system
  (/var & /etc) writable.
- Update units tests to account for the new rw karg

(cherry-picked from a commit 0e00c90)

Related: RHEL-2250
@poncovka
Copy link
Contributor Author

It looks like the ostree container support (introduced in #5399) and the related bootupd support (from #5424) don't work without this commit. The installed systems fail to boot. @cgwalters Is it ok to port this change to RHEL 9?

@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

@cgwalters
Copy link
Contributor

Yes.

One thing I would note here is with bootc, I've been trying hard to have the container image own its own installation! So if we did #5197 this would automatically happen because bootc install to-filesystem handles this stuff; xref https://github.com/containers/bootc/blob/cbe606265bccda19f6ce01a0816498c5263cc33e/lib/src/install.rs#L597

It's always basically been a bug that this stuff lives in the thing doing the installation...really an ostree design flaw in the end. We've actually fixed that recently with ostreedev/ostree#2930

However the thing that is currently definitely required is that rw end up on the initial kernel commandline.

@cgwalters
Copy link
Contributor

In theory I guess, ostree could just try to force on the rw thing if it detects it's needed...it's just messy and a layering violation.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@M4rtinK M4rtinK added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Jan 29, 2024
@M4rtinK M4rtinK merged commit 34141ff into rhinstaller:rhel-9 Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
Development

Successfully merging this pull request may close these issues.

5 participants