Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR 5297 content from Fedora-39 branch #5324

Closed

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Nov 14, 2023

Hello @KKoukiou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 80:5: E303 too many blank lines (2)

Comment last updated at 2024-02-06 15:45:13 UTC

@github-actions github-actions bot added the f40 label Nov 14, 2023
@KKoukiou
Copy link
Contributor Author

This needs to be tested with the Web UI

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Nov 14, 2023
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 14, 2024
@VladimirSlavik
Copy link
Contributor

What's the testing that it needs? Is it something that's now available?

@KKoukiou
Copy link
Contributor Author

What's the testing that it needs? Is it something that's now available?

we dont have automation for live images, so that needs to be tested manually.

@VladimirSlavik
Copy link
Contributor

Oh :(

@github-actions github-actions bot removed the stale label Jan 19, 2024
jlintonarm and others added 2 commits February 6, 2024 16:44
Live images are already installed with grub2 and cannot be changed on
the fly to systemd-boot (well at least without a lot of extra
work). In case the user passed one of the systemd-boot options to
anaconda, we should be a bit more graceful than failing to run the
updateloader entries script as currently happens.

This change, when run on non webUI installs results in a popup
notifying the user there is an error in the bootloader configuration
and asking if they would like to ignore it.

Resolves: rhbz#2234638
Signed-off-by: Jeremy Linton <[email protected]>
The installer is not able to verify requirements of the selected bootloader with
other types of payload, like live images and rpmostree installations. Let's
allow systemd-boot only for package installations for now and deal with other
use cases later.

Related: rhbz#2234638
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Feb 6, 2024

Something wrong with RPM builds here. Closing and reopening for COPR from packit to be recreated.

@KKoukiou KKoukiou closed this Feb 6, 2024
@KKoukiou KKoukiou deleted the sdboot-cherry-pickpr-5297 branch February 6, 2024 15:58
@KKoukiou KKoukiou restored the sdboot-cherry-pickpr-5297 branch February 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge this pull request! f40
Development

Successfully merging this pull request may close these issues.

5 participants