-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: replacing Tooltip for HelperText in Storage devices step #4875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acruzgon there was not intention to change the component in use. We want that we keep using the tooltip but just show that when the button receives focus. This is possible, see https://www.patternfly.org/v4/components/button/#aria-disabled-examples
Your suggested solution has the problem that does not align with patternfly guidelines, as HelperText is expected to be used inside forms. And also the page footer will jump a bit because of the text appeeding/hiding when the users selects all/unselects all disks.
Hey! So here's the reasoning for the change in the UI:
In Cockpit, we use this pattern of putting Help Text at the bottom near the action buttons in modals; as the action that someone would typically use here (next) has an inactive state, it's good to clarify why (which happened with a tooltip, but that was not obvious). As Anaconda is a wizard, this is the reinterpretation of the same concept, but applied to a wizard instead. We can't really target each item (especially if there is more than one) here. And if we had some sort of message at the top, it should shift everything down (even more than shifting the border line up). Plus, having an alert before someone has done anything is a bad idea. Alerts need to be the result of an action that was taken. (And hopefully we have the first reasonable disk selected by default anyway, especially if there's only one disk.) Hiding the reason behind a tooltip is similar to the "mystery meat navigation" issue. https://en.wikipedia.org/wiki/Mystery_meat_navigation (where things that aren't obvious, but are still important, are hidden away). Therefore, all this taken into consideration: The most contextual location for a message as to why you cannot proceed is next to the place where you normally click next, in an obvious way. |
e1be5e5
to
b216982
Compare
/kickstart-test --waive webui only |
INSTALLER-3418
When there are no disks selected, the Next button is disabled and a helper text indicates user to make a disk selection in order to continue with installation.