Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Xorg server and libxklavier #5829

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Drop Xorg server and libxklavier #5829

wants to merge 31 commits into from

Conversation

jkonecny12
Copy link
Member

@jkonecny12 jkonecny12 commented Aug 14, 2024 •
edited
Loading

This is port of the:

It is first part of the Wayland migration patches to Fedora.

Resolves: https://fedoraproject.org/wiki/Changes/Anaconda_As_Native_Wayland_Application

TODO:

Ready for review

  • Tested on boot.iso - works as expected
  • Tested on KDE Live - works almost as expected (there is minor bug when switching keyboard layout in system)
  • Tested on Sway Live - works with additional fixes (new sway-config package needs release + Remove variant before setting new localed layouts alebastr/sway-systemd#30)
  • Tested on Fedora Workstation - works as expected (not impacted by this change from my testing)

After this merge

@jkonecny12 jkonecny12 added blocked Don't merge this pull request! release note required Write a release note for this change. f41 labels Aug 14, 2024
@github-actions github-actions bot added the infrastructure Changes affecting mostly infrastructure label Aug 14, 2024
@pep8speaks
Copy link

pep8speaks commented Aug 21, 2024 •
edited
Loading

Hello @jkonecny12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 167:100: E501 line too long (120 > 99 characters)

Comment last updated at 2024-09-25 18:38:50 UTC

@jkonecny12
Copy link
Member Author

Add #5842 on top of the pile.

@jkonecny12 jkonecny12 added f42 Fedora 42 and removed infrastructure Changes affecting mostly infrastructure labels Aug 21, 2024
@jkonecny12 jkonecny12 mentioned this pull request Aug 22, 2024
Merged
@Conan-Kudo
Copy link
Contributor

Can we please put the VNC stuff back? GRD supports VNC and RDP, and there are many more high quality VNC clients than there are RDP clients for Linux. And even the first party Mac remote desktop client is VNC-based, not RDP.

@Conan-Kudo Conan-Kudo mentioned this pull request Aug 30, 2024
Draft
@jkonecny12 jkonecny12 removed the f41 label Aug 30, 2024
@jkonecny12
Copy link
Member Author

@Conan-Kudo as said a few times. I won't do that from start. This is already quite heavy patch set and getting into this VNC would make it just heavier.

Also based on the GRD maintainer reply it doesn't sound wise move in the current situation https://lists.fedoraproject.org/archives/list/[email protected]/message/G4DFKOUDDDDYHNQBNYRH52XVYKWK5X2U/

@jkonecny12
Copy link
Member Author

Added support for localed. Unfortunately we can't merge this until this is resolved https://pagure.io/releng/issue/12275 because it's blocking one of our new dependency.

@jkonecny12
Copy link
Member Author

Also I need to do testing on Live to find how it behaves there.

@jkonecny12
Copy link
Member Author

UPDATED:

  • Fix pep8 failures

@jkonecny12
Do not create GRDServer on Live ISO
efda6c7 
The GRDServer class have checks in the __init__ method which starts to
complain about missing GRD in the system. That doesn't apply in Live
environment where we don't support GRD in the first place.
@jkonecny12
Remove Wayland detection logic from code
efd866c 
This logic was used to disable keyboard switching for given system.
However, we we support even Wayland systems with the new solution, so
let's remove this.
@jkonecny12
Set --rdp in liveinst unsupported
870942d 
Previously it was vnc but we switched to RDP instead.
@jkonecny12
Add release-notes for Wayland migration
cedfa2c 
https://fedoraproject.org/wiki/Changes/Anaconda_As_Native_Wayland_Application
@jkonecny12
Do not change compositor options when not defined
4cd89b3 
If Anaconda will set keyboard layouts to compositor but options are
missed then we shouldn't change the compositor options but rather use
what is already set.

This will avoid problematic behavior of changing what user has defined
in the system or similar cases. Also we have this tested in
kickstart-tests, so this commit is fixing these tests.

Also fix existing tests and cover this functionality by tests.
@jkonecny12
Fix typo in the GRD source file name
d963400
@jkonecny12
Disable fedora-cisco repository in our containers
da20f70 
We need to disable these repositories to avoid dependencies from it.

With this changeset we depends on gnome-remote-desktop which depends on
librdp which depends (Fedora only) on openh264. However, if fedora-cisco
repository is not enabled it will instead install noopenh264 package
which is a stub package in the main repositories.
@jkonecny12
Copy link
Member Author

Rebased.

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

/kickstart-test --skip-testtypes whatever

@jkonecny12
Copy link
Member Author

/kickstart-test --kstest-pr 1309 ui_rdp

@jkonecny12
Copy link
Member Author

jkonecny12 commented Sep 25, 2024 •
edited
Loading

The one failing KS test on all suite run is this issue rhinstaller/kickstart-tests#1296 so it is not caused by this PR.

@jkonecny12 jkonecny12 mentioned this pull request Sep 25, 2024
Merged
@jkonecny12 jkonecny12 removed the blocked Don't merge this pull request! label Sep 25, 2024
@jkonecny12
Create GRDServer class only when required
db576ec 
Move the GRDServer class creation to the end of the `setup_display`
method. This class have checks for binaries in the `__init__` method
which is causing early failures. Also do not create the class if it is
not really used.
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

/kickstart-test --kstest-pr 1309 ui_rdp

@jkonecny12
Copy link
Member Author

jkonecny12 commented Sep 25, 2024 •
edited
Loading

UPDATED:

  • Add a new commit to avoid creation of the GRDServer class before we know it will be used.
    • This should make the code more robust against running in unsupported environment.

jkonecny12 added a commit to jkonecny12/anaconda-webui that referenced this pull request Sep 30, 2024
@jkonecny12
Hotfix for Anaconda Wayland migration changes
a9f949e 
There is a new patchset to migrate Anaconda to Wayland native
application. This patchset is unfortunately quite big and complicated.
rhinstaller/anaconda#5829

Current Web UI testing depends on updates image creation from the
Anaconda RPMs which are downloaded from Rawhide and/or COPR repos.
However, we are hitting issues for updates images in this case.

- Removal of spoke in Anaconda will not be covered by updates image.
  This is expected because RPM don't have information that some file
  was removed. Usually this is not an issue because the removed code is
  not imported. Unfortunately, here the code is imported by our
  dynamic spoke importer. That will result in traceback because
  of missing imports in the removed spoke.
- The patchset in Anaconda is adding new dependencies required to be
  able to start the Wayland environment, however, these are not covered
  when an updates image is created because we can't tell which deps are
  new and should be part of the ISO.

We should resolve this somehow by improving the workflow in the future.
For now we can continue with this hotfix.
@jkonecny12 jkonecny12 mentioned this pull request Sep 30, 2024
Open
M4rtinK
M4rtinK approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the changes for RDP startup specifically - looks good to me, thanks! :)

KKoukiou pushed a commit to jkonecny12/anaconda-webui that referenced this pull request Oct 2, 2024
@jkonecny12 @KKoukiou
Hotfix for Anaconda Wayland migration changes
ff38ed9 
There is a new patchset to migrate Anaconda to Wayland native
application. This patchset is unfortunately quite big and complicated.
rhinstaller/anaconda#5829

Current Web UI testing depends on updates image creation from the
Anaconda RPMs which are downloaded from Rawhide and/or COPR repos.
However, we are hitting issues for updates images in this case.

- Removal of spoke in Anaconda will not be covered by updates image.
  This is expected because RPM don't have information that some file
  was removed. Usually this is not an issue because the removed code is
  not imported. Unfortunately, here the code is imported by our
  dynamic spoke importer. That will result in traceback because
  of missing imports in the removed spoke.
- The patchset in Anaconda is adding new dependencies required to be
  able to start the Wayland environment, however, these are not covered
  when an updates image is created because we can't tell which deps are
  new and should be part of the ISO.

We should resolve this somehow by improving the workflow in the future.
For now we can continue with this hotfix.
KKoukiou pushed a commit to jkonecny12/anaconda-webui that referenced this pull request Oct 2, 2024
@jkonecny12 @KKoukiou
Hotfix for Anaconda Wayland migration changes
57f6aff 
There is a new patchset to migrate Anaconda to Wayland native
application. This patchset is unfortunately quite big and complicated.
rhinstaller/anaconda#5829

Current Web UI testing depends on updates image creation from the
Anaconda RPMs which are downloaded from Rawhide and/or COPR repos.
However, we are hitting issues for updates images in this case.

- Removal of spoke in Anaconda will not be covered by updates image.
  This is expected because RPM don't have information that some file
  was removed. Usually this is not an issue because the removed code is
  not imported. Unfortunately, here the code is imported by our
  dynamic spoke importer. That will result in traceback because
  of missing imports in the removed spoke.
- The patchset in Anaconda is adding new dependencies required to be
  able to start the Wayland environment, however, these are not covered
  when an updates image is created because we can't tell which deps are
  new and should be part of the ISO.

We should resolve this somehow by improving the workflow in the future.
For now we can continue with this hotfix.
KKoukiou pushed a commit to jkonecny12/anaconda-webui that referenced this pull request Oct 2, 2024
@jkonecny12 @KKoukiou
Hotfix for Anaconda Wayland migration changes
c46b726 
There is a new patchset to migrate Anaconda to Wayland native
application. This patchset is unfortunately quite big and complicated.
rhinstaller/anaconda#5829

Current Web UI testing depends on updates image creation from the
Anaconda RPMs which are downloaded from Rawhide and/or COPR repos.
However, we are hitting issues for updates images in this case.

- Removal of spoke in Anaconda will not be covered by updates image.
  This is expected because RPM don't have information that some file
  was removed. Usually this is not an issue because the removed code is
  not imported. Unfortunately, here the code is imported by our
  dynamic spoke importer. That will result in traceback because
  of missing imports in the removed spoke.
- The patchset in Anaconda is adding new dependencies required to be
  able to start the Wayland environment, however, these are not covered
  when an updates image is created because we can't tell which deps are
  new and should be part of the ISO.

We should resolve this somehow by improving the workflow in the future.
For now we can continue with this hotfix.
KKoukiou pushed a commit to jkonecny12/anaconda-webui that referenced this pull request Oct 2, 2024
@jkonecny12 @KKoukiou
tests: hotfix for Anaconda Wayland migration changes
af6d254 
There is a new patchset to migrate Anaconda to Wayland native
application. This patchset is unfortunately quite big and complicated.
rhinstaller/anaconda#5829

Current Web UI testing depends on updates image creation from the
Anaconda RPMs which are downloaded from Rawhide and/or COPR repos.
However, we are hitting issues for updates images in this case.

- Removal of spoke in Anaconda will not be covered by updates image.
  This is expected because RPM don't have information that some file
  was removed. Usually this is not an issue because the removed code is
  not imported. Unfortunately, here the code is imported by our
  dynamic spoke importer. That will result in traceback because
  of missing imports in the removed spoke.
- The patchset in Anaconda is adding new dependencies required to be
  able to start the Wayland environment, however, these are not covered
  when an updates image is created because we can't tell which deps are
  new and should be part of the ISO.

We should resolve this somehow by improving the workflow in the future.
For now we can continue with this hotfix.
@KKoukiou
Copy link
Contributor

KKoukiou commented Oct 2, 2024

/build-image --live

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Images built based on commit db576ec:

  • Live: success

Download the images from the bottom of the job status page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
f42 Fedora 42 release note required Write a release note for this change.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkonecny12 @pep8speaks @Conan-Kudo @M4rtinK @KKoukiou @jexposit @rvykydal