Hotfix for Anaconda Wayland migration changes #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
reviewed
Oct 1, 2024
There was a problem hiding this comment.
@jkonecny12 I see in the journals that the is anaconda traceback.
pyanaconda.errors.ExitError: /usr/libexec/anaconda/run-in-new-session exited on signal 9
KKoukiou
force-pushed
the
main-ugly-hotfix-for-anaconda-wayland-migration
branch
3 times, most recently
from
8243617
to
c46b726
Compare
There is a new patchset to migrate Anaconda to Wayland native application. This patchset is unfortunately quite big and complicated. rhinstaller/anaconda#5829 Current Web UI testing depends on updates image creation from the Anaconda RPMs which are downloaded from Rawhide and/or COPR repos. However, we are hitting issues for updates images in this case. - Removal of spoke in Anaconda will not be covered by updates image. This is expected because RPM don't have information that some file was removed. Usually this is not an issue because the removed code is not imported. Unfortunately, here the code is imported by our dynamic spoke importer. That will result in traceback because of missing imports in the removed spoke. - The patchset in Anaconda is adding new dependencies required to be able to start the Wayland environment, however, these are not covered when an updates image is created because we can't tell which deps are new and should be part of the ISO. We should resolve this somehow by improving the workflow in the future. For now we can continue with this hotfix.
KKoukiou
force-pushed
the
main-ugly-hotfix-for-anaconda-wayland-migration
branch
2 times, most recently
from
98558a6
to
1f088e7
Compare
Because the updates.img got even bigger.
KKoukiou
force-pushed
the
main-ugly-hotfix-for-anaconda-wayland-migration
branch
from
1f088e7
to
55f49fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new patchset to migrate Anaconda to Wayland native application. This patchset is unfortunately quite big and complicated. rhinstaller/anaconda#5829
Current Web UI testing depends on updates image creation from the Anaconda RPMs which are downloaded from Rawhide and/or COPR repos. However, we are hitting issues for updates images in this case.
We should resolve this somehow by improving the workflow in the future. For now we can continue with this hotfix.